Identify abortion with dumping empty DataFrame#451
Merged
kitagry merged 1 commit intom3dev:masterfrom Mar 6, 2025
Merged
Conversation
hirosassa
approved these changes
Mar 5, 2025
Collaborator
hirosassa
left a comment
hirosassa
left a comment
There was a problem hiding this comment.
added a comment but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When a task failed and raised an exception, we want to identify whether its reason is dumping an empty DataFrame (with
fail_on_empty_dumpoption) or the others.Implementation
Raise specific exception for that case.